[SCM-907] GitScmProviderRepository#parseUrl() does not comply with RFC 3986 and RFC 8089

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.10.0
• Component/s: maven-scm-provider-gitexe, maven-scm-provider-jgit
• Assignee: Unassigned
• Reporter: Michael Osipov
• Created: 08/Sep/18 21:41
• Updated: 08/Sep/18 22:16

Description

This issue was been found on one of Jenkins slaves. Consider the following path: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2\m\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target. THe aforementioned class outputs:

file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
file://2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target

The parse logic incorrectly assumes that the last @ is for the user info. According to RFC 8089 a file URL may contain this information, but our parser would still fail becuase it uses lastIndexOf. It must stop searching to the first slash.