[SCM-879] JazzChangeLogCommandTest#testListChangesetConsumerWithTimeOnly() fails with NPE on Java 10

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.5
• Fix Version/s: 1.10.0
• Component/s: maven-scm-provider-jazz

Environment

Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T20:49:05+01:00)
Maven home: D:\Entwicklung\Programme\apache-maven-3.5.3\bin\..
Java version: 10, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk-10
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 01/Apr/18 23:06
• Updated: 02/Apr/18 15:41
• Resolved: 02/Apr/18 15:41

Description

Surefire says:

Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.917 sec <<< FAILURE! - in org.apache.maven.scm.provider.jazz.command.changelog.JazzChangeLogCommandTest
testListChangesetConsumerWithTimeOnly(org.apache.maven.scm.provider.jazz.command.changelog.JazzChangeLogCommandTest)  Time elapsed: 0.678 sec  <<< ERROR!
java.lang.NullPointerException
        at org.apache.maven.scm.provider.jazz.command.changelog.JazzChangeLogCommandTest.testListChangesetConsumerWithTimeOnly(JazzChangeLogCommandTest.java:294)

The error is rooted in org.apache.maven.scm.provider.jazz.command.changelog.JazzListChangesetConsumer.processModifiedLine(String). It does not parse the given time with JAZZ_TIMESTAMP_PATTERN_TIME and Locale.ENGLISH, but relies on the system locale which will fail for non-English parsing AM/PM.

Issue Links

• is depended upon by: SCM-880 Maven SCM Client fails to be assembled on Java 10