[SCM-863] NPE in GlobalOptions.setCVSRoot(null) with newer cvsclient

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.5
• Fix Version/s: 1.10.0
• Component/s: maven-scm-provider-cvs
• Assignee: Olivier Lamy
• Reporter: Ilya Basin
• Created: 16/Feb/18 11:32
• Updated: 03/Mar/18 09:58
• Resolved: 03/Mar/18 09:58

Description

I'm running mvn test on Windows with CVSNT 2.5.03.2382 installed. To test another bug I upgraded the cvsclient dependency to the Tip of the Netbeans Mercurial repo (created a local maven artifact for that).

My command line is:

mvn test -DcvsClientLog=system -Dtest=CvsJavaChangeLogCommandTest#testGetCommandWithBranchOrTag

The test is failing with:

Running org.apache.maven.scm.provider.cvslib.cvsjava.command.changelog.CvsJavaChangeLogCommandTest
Test command line: cmd.exe /X /C "cvs -f -d C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\src\test\repository
co test-repo/changelog"
[INFO] Executing: cmd.exe /X /C "cvs -z3 -f -d :local:C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\src\test\r
epository -q log -r1.107.4"
[INFO] Working directory: C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\target\scm-test\working-copy
java.lang.NullPointerException
        at org.netbeans.lib.cvsclient.CVSRoot.<init>(CVSRoot.java:239)
        at org.netbeans.lib.cvsclient.CVSRoot.parse(CVSRoot.java:159)
        at org.netbeans.lib.cvsclient.command.GlobalOptions.setCVSRoot(GlobalOptions.java:468)
        at org.apache.maven.scm.provider.cvslib.cvsjava.util.CvsConnection.processCommand(CvsConnection.java:406)
        at org.apache.maven.scm.provider.cvslib.cvsjava.command.changelog.CvsJavaChangeLogCommand.executeCvsCommand(CvsJavaChangeLogCommand.java:55)
        at org.apache.maven.scm.provider.cvslib.command.changelog.AbstractCvsChangeLogCommand.executeChangeLogCommand(AbstractCvsChangeLogCommand.java:124)
        at org.apache.maven.scm.provider.cvslib.command.changelog.AbstractCvsChangeLogCommand.executeChangeLogCommand(AbstractCvsChangeLogCommand.java:64)
        at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:114)
        at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:59)
        at org.apache.maven.scm.provider.cvslib.AbstractCvsScmProvider.executeCommand(AbstractCvsScmProvider.java:769)
        at org.apache.maven.scm.provider.cvslib.AbstractCvsScmProvider.changelog(AbstractCvsScmProvider.java:282)
        at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:295)
        at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:283)
        at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:257)
        at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:239)
        at org.apache.maven.scm.provider.cvslib.command.changelog.CvsChangeLogCommandTest.testChangeLog(CvsChangeLogCommandTest.java:90)
        at org.apache.maven.scm.provider.cvslib.command.changelog.CvsChangeLogCommandTest.testGetCommandWithBranchOrTag(CvsChangeLogCommandTest.java:71)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at junit.framework.TestCase.runTest(TestCase.java:176)
        at junit.framework.TestCase.runBare(TestCase.java:141)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at junit.framework.TestCase.run(TestCase.java:129)
        at junit.framework.TestSuite.runTest(TestSuite.java:255)
        at junit.framework.TestSuite.run(TestSuite.java:250)
        at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
        at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121

Issue Links

• links to: GitHub Pull Request #61