Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-835

includes directive doesn't work correctly when other files in directory changes

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.10.0
    • Fix Version/s: 1.11.1
    • Labels:
      None
    • Flags:
      Patch

      Description

      We have a scenario, when we have to commit only one file, for example "LICENSE.md".

      When we use

                          <includes>LICENSE.md</includes>
      

      GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir() and if there are any changes, passes them to "commit" and "push" phases.

      If there are any other files changed (except LICENSE.md), than statusConsumer.getChangedFiles() is not empty and we proceed. But if we didn't made any changes to our file, "commit" phase will fail, as there is nothing to commit (in terms of our fileSet).

      I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not give us status of changed files if they are not in a fileSet.

        Attachments

          Activity

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              shvar Eli Shvartsman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: