[SCM-797] gitexe checkIn() fails due to Windows command line length limitation

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.4
• Fix Version/s: 1.10.0
• Component/s: maven-scm-provider-gitexe
• Labels: Maven SCM
• Environment: Windows
• Flags: Patch
• Assignee: Michael Osipov
• Reporter: Radovan Murin
• Created: 08/Apr/15 09:21
• Updated: 04/Apr/20 10:52
• Resolved: 11/May/18 00:52

Description

Hello,

I noticed that for a project with a large amount of pom files the prepare command of the release plugin fails when it tries to git add all of the poms.

The failure happens because the SCM plugin attempts to git add all of the files at once which fails on Windows machines due to the command line length limitation.

I have written a small fix and created a pull request
https://github.com/apache/maven-scm/pull/30

Basicaly, with the fix, the command git add iterates on all files rather than adding them in one command. The fix was already present in the code in
the GitAddCommand.java. However there was one more place in the code with the bug.

Issue Links

• is depended upon by: MRELEASE-1026 release:perform issues a git add with more than 27000 bytes.
• is duplicated by: SCM-714 mvn release:prepare fails if the command line is too long on windows
• links to: GitHub Pull Request #49