[SCM-777] scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 1.11.2
• Component/s: maven-plugin
• Environment: Java 7 x64 on Windows 7
• Assignee: Michael Osipov
• Reporter: Mark Herman
• Created: 12/Sep/14 14:19
• Updated: 05/Feb/19 14:38
• Resolved: 25/Jan/19 07:35

Description

org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl() uses...

 Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) 

...in order to check if it should check the repository on scm:validate. This will only react to the system property, and not to the maven configuration.

Result: no maven config will enable the check working directory option, only passing it in as a jvm argument.

Expected: this should work:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-scm-plugin</artifactId>
    <configuration>
        <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl>  <!-- this configuration is ignored, don't know why -->
    </configuration>
    <executions>
        <execution>
          <phase>validate</phase>
          <configuration>
            <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl> <!-- neither does this -->
          </configuration>
          <goals>
            <goal>validate</goal>
          </goals>
        </execution>
    </executions>
</plugin>

Workaround: Use <systemProperty> section. Tried <systemPropertyVariables> and for some reason that didn't appear to work.

Issue Links

• is caused by: SCM-741 scm:validate for svn should offer a way to check the current directory actually matches what's declared in the pom
• is caused by: SCM-781 Add a goal to recursively validate SCM url