Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-777

scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.11.2
    • Component/s: maven-plugin
    • Labels:
      None
    • Environment:
      Java 7 x64 on Windows 7

      Description

      org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl() uses...

       Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) 

      ...in order to check if it should check the repository on scm:validate. This will only react to the system property, and not to the maven configuration.

      Result: no maven config will enable the check working directory option, only passing it in as a jvm argument.

      Expected: this should work:

      <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-scm-plugin</artifactId>
          <configuration>
              <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl>  <!-- this configuration is ignored, don't know why -->
          </configuration>
          <executions>
              <execution>
                <phase>validate</phase>
                <configuration>
                  <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl> <!-- neither does this -->
                </configuration>
                <goals>
                  <goal>validate</goal>
                </goals>
              </execution>
          </executions>
      </plugin>
      
      

      Workaround: Use <systemProperty> section. Tried <systemPropertyVariables> and for some reason that didn't appear to work.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                michael-o Michael Osipov
                Reporter:
                maikhorma Mark Herman
              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: