[SCM-745] Perforce blame result parsing too greedy

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.1, 1.9
• Fix Version/s: 1.11.1
• Component/s: maven-scm-provider-perforce
• Flags: Patch
• Assignee: Michael Osipov
• Reporter: Todd Currie
• Created: 31/Mar/14 17:38
• Updated: 18/Aug/18 22:46
• Resolved: 18/Aug/18 22:46

Description

The regex for the parsing of the author information from the command line results is incorrect. It is overly greedy and is consuming additional characters depending upon the change comments entered by the author.

org.apache.maven.scm.provider.perforce.command.blame.PerforceFilelogConsumer

39c39
< private static final String LINE_PATTERN = "#(
d+).on (.) by (.*)@";
—
> private static final String LINE_PATTERN = "#(
d+).?on (.?) by (.*?)@";

Example of failure:
Changelist: 624405
Date: 2013/07/19 14:05
Client: ws_advertising
User: mccabej
Description:
Fix retry order so that the @Retryable proxy always executes first.

Resulting Author is "mccabej@ws_advertising (ktext) 'Fix retry order so that the "