Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-745

Perforce blame result parsing too greedy

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.1, 1.9
    • Fix Version/s: 1.11.1
    • Labels:
      None
    • Flags:
      Patch

      Description

      The regex for the parsing of the author information from the command line results is incorrect. It is overly greedy and is consuming additional characters depending upon the change comments entered by the author.

      org.apache.maven.scm.provider.perforce.command.blame.PerforceFilelogConsumer

      39c39
      < private static final String LINE_PATTERN = "#(
      d+).on (.) by (.*)@";

      > private static final String LINE_PATTERN = "#(
      d+).?on (.?) by (.*?)@";

      Example of failure:
      Changelist: 624405
      Date: 2013/07/19 14:05
      Client: ws_advertising
      User: mccabej
      Description:
      Fix retry order so that the @Retryable proxy always executes first.

      Resulting Author is "mccabej@ws_advertising (ktext) 'Fix retry order so that the "

        Attachments

          Activity

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              tcurrie Todd Currie
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: