[SCM-726] AbstractCvsScmProvider.parseScmUrl for ext transport should expect 4 or 5 tokens

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Auto Closed
• Affects Version/s: 1.8.1
• Component/s: maven-scm-provider-cvs
• Assignee: Unassigned
• Reporter: Przemyslaw Fusik
• Created: 12/Jul/13 03:59
• Updated: 16/Mar/18 22:39
• Resolved: 16/Mar/18 22:39

Description

According to http://maven.apache.org/scm/cvs.html ext transport url may contain 4 or 5 (including port) tokens (excluding the first two tokens 'scm' and 'cvs' that are consumed before)

scm:cvs<delimiter>ext<delimiter>[username@]servername[<delimiter>port]<delimiter>path_to_repository<delimiter>module_name

but the code inside AbstractCvsScmProvider.parseScmUrl

if ( tokens.length != 4 && transport.equalsIgnoreCase( TRANSPORT_EXT ) )
            {
                result.getMessages().add( "The connection string contains too few tokens." );

                return result;
            }

requires 4 tokens and adds misleading message.