[SCM-721] Mercurial ChangeLog command doesn't respect limit

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Affects Version/s: 1.8.1
• Component/s: maven-scm-provider-mercurial (hg)
• Assignee: Unassigned
• Reporter: Richard DiCroce
• Created: 23/May/13 14:53
• Updated: 16/Mar/18 22:40
• Resolved: 16/Mar/18 22:40

Description

The changeLog() method does not respect the limit parameter. This appears to happen because the limit parameter gets lost in the middle of the method chain:
1. HgScmProvider.changelog() calls AbstractCommand.execute()
2. AbstractCommand.execute() calls AbstractChangeLogCommand.executeCommand()
3. AbstractChangeLogCommand.executeCommand() calls one of two overloads of executeChangeLogCommand(), both of which are deprecated. Neither takes a limit parameter, and the limit parameter is lost at this point.

I encountered this problem on Mercurial, but other providers will also be affected unless their concrete ChangeLogCommand implementations override executeCommand() to call a method that supports the limit parameter. Curiously, HgChangeLogCommand does have such a method, but it is never called.