[SCM-707] Maven SCM should encode username and password in URL

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8
• Fix Version/s: 1.9
• Component/s: maven-scm-provider-gitexe, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
• Assignee: Robert Scholte
• Reporter: Sébastien Deleuze
• Created: 02/Jan/13 09:32
• Updated: 15/Apr/17 21:55
• Resolved: 15/Apr/17 21:49

Description

When using SCM over http (tested in my case with Git), Maven SCM should encode username and password before using them with URL.

In order to reproduce, try to create a release with Maven Release and a user with a password containing @ character, it will fail.

Please find bellow cmd output :

[INFO] Executing: /bin/sh -c cd /DATA/jenkins/workspace/path && git push http://username:*********@git.forge/git/project/ master:master

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4:prepare (default-cli) on project project: Unable to commit files
Provider message:
The git-push command failed.
Command output:
error: Couldn't resolve host '@*******@git.forge' while accessing http://username:*********@git.forge/git/project/info/refs
fatal: HTTP request failed

Issue Links

• breaks: SCM-846 userInfo in Git HTTP URLs not escaped according to RFC 3986
• links to: GitHub Pull Request #53