Maven SCM
  1. Maven SCM
  2. SCM-630

Request to include MKS Integrity SCM Provider along with the rest of the Maven SCM Providers

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6
    • Component/s: maven-scm-api
    • Labels:
      None
    • Environment:
      Unix and Windows
    • Flags:
      Patch

      Description

      I've developed an SCM Provider for MKS Integrity.
      I would like to contribute this code to the Apache community for inclusion on the Maven SCM Provider list

      1. javadocs.zip
        312 kB
        Cletus D'Souza
      2. maven-scm-provider-integrity-1.0-SNAPSHOT.jar
        76 kB
        Cletus D'Souza
      3. source.zip
        512 kB
        Cletus D'Souza
      4. maven-scm-provider-integrity-1.0-SNAPSHOT.jar
        76 kB
        Cletus D'Souza
      5. source.zip
        512 kB
        Cletus D'Souza
      6. javadocs.zip
        312 kB
        Cletus D'Souza
      7. UnitTests.zip
        22 kB
        Cletus D'Souza

        Activity

        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        the file mksapi-jar-4.10.9049.jar contains some classes com/mks/api what is license for this library ? (note it contains some apache classes too : commons logging, commons-httpclient)
        could it be deployed to central maven repository ?

        Show
        Olivier Lamy (*$^¨%`£) added a comment - the file mksapi-jar-4.10.9049.jar contains some classes com/mks/api what is license for this library ? (note it contains some apache classes too : commons logging, commons-httpclient) could it be deployed to central maven repository ?
        Hide
        Cletus D'Souza added a comment -

        The mksapi-jar-4.10.9049.jar can be redistributed. However, I cannot provide the sources for it.

        Show
        Cletus D'Souza added a comment - The mksapi-jar-4.10.9049.jar can be redistributed. However, I cannot provide the sources for it.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        redistributed sure.
        But what is the license ?
        And can you contact the owner to ask him about deploying it to central maven repo ?
        see http://maven.apache.org/guides/mini/guide-central-repository-upload.html

        Show
        Olivier Lamy (*$^¨%`£) added a comment - redistributed sure. But what is the license ? And can you contact the owner to ask him about deploying it to central maven repo ? see http://maven.apache.org/guides/mini/guide-central-repository-upload.html
        Hide
        Cletus D'Souza added a comment -

        Fixed minor issue with scm:diff

        Show
        Cletus D'Souza added a comment - Fixed minor issue with scm:diff
        Hide
        Cletus D'Souza added a comment -

        Fixed minor issue with scm:diff

        Show
        Cletus D'Souza added a comment - Fixed minor issue with scm:diff
        Hide
        Cletus D'Souza added a comment -

        Java docs for the latest source

        Show
        Cletus D'Souza added a comment - Java docs for the latest source
        Hide
        Cletus D'Souza added a comment -

        I'm not sure what you mean by "license" for the jar. Can you explain?
        I'm still waiting to hear back from the owner about deploying the jar to maven central. Couple questions:
        1) Can I still proceed with this submission without the jar?
        2) Is it possible to deploy the jar to maven central without sources and <scm> tags in the pom.xml?
        Finally, can you remove the attachments added on 8/22? I've updated the source code to include a minor fix.

        Show
        Cletus D'Souza added a comment - I'm not sure what you mean by "license" for the jar. Can you explain? I'm still waiting to hear back from the owner about deploying the jar to maven central. Couple questions: 1) Can I still proceed with this submission without the jar? 2) Is it possible to deploy the jar to maven central without sources and <scm> tags in the pom.xml? Finally, can you remove the attachments added on 8/22? I've updated the source code to include a minor fix.
        Show
        Cletus D'Souza added a comment - mksapi-jar-4.10.9049 has been staged: https://oss.sonatype.org/content/repositories/central_bundles-084/com/mks/api/mksapi-jar/4.10.9049/
        Hide
        Cletus D'Souza added a comment -

        mksapi-jar-4.10.9049 has been published to Maven Central: http://repo1.maven.org/maven2/com/mks/api/mksapi-jar/4.10.9049/
        Can we move forward with the SCM Provider now?

        Show
        Cletus D'Souza added a comment - mksapi-jar-4.10.9049 has been published to Maven Central: http://repo1.maven.org/maven2/com/mks/api/mksapi-jar/4.10.9049/ Can we move forward with the SCM Provider now?
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        yup I'm working on integrate it.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - yup I'm working on integrate it.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        all committed.
        I wonder if you could provide some unit tests ???
        Thanks !

        Show
        Olivier Lamy (*$^¨%`£) added a comment - all committed. I wonder if you could provide some unit tests ??? Thanks !
        Hide
        Cletus D'Souza added a comment -

        Sure, I can work on creating the unit tests. Any idea when maven scm 1.6 is scheduled to be released?

        Show
        Cletus D'Souza added a comment - Sure, I can work on creating the unit tests. Any idea when maven scm 1.6 is scheduled to be released?
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        No idea yet for the release.
        I have to review some issues first.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - No idea yet for the release. I have to review some issues first.
        Hide
        Cletus D'Souza added a comment - - edited

        Attached are the unit tests that make the most sense. Some tests are intentionally excluded as some test commands execute more than one scm command (ex: login - consumed by all commands, edit - consumed by checkin, etc.). Also, I've excluded tests for CLI based commands (blame, fileinfo, and diff) as it doesn't make sense to simply assert the command line string. It almost seems like hardcoding it in two places, so theres little value. Hopefully these tests are sufficient for the intial publication/release.

        Show
        Cletus D'Souza added a comment - - edited Attached are the unit tests that make the most sense. Some tests are intentionally excluded as some test commands execute more than one scm command (ex: login - consumed by all commands, edit - consumed by checkin, etc.). Also, I've excluded tests for CLI based commands (blame, fileinfo, and diff) as it doesn't make sense to simply assert the command line string. It almost seems like hardcoding it in two places, so theres little value. Hopefully these tests are sufficient for the intial publication/release.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        Thanks !
        I have excluded some by default. You can run it tru the profile tck-mks.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - Thanks ! I have excluded some by default. You can run it tru the profile tck-mks.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        we are fine IMHO

        Show
        Olivier Lamy (*$^¨%`£) added a comment - we are fine IMHO

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Cletus D'Souza
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development