Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-504

CVS Tag Command Not Respecting Single File in ScmFileSet

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.1
    • Fix Version/s: None
    • Component/s: maven-scm-provider-cvs
    • Labels:
      None

      Description

      The CVS tag command is not checking the given ScmFileSet for individual files. This code snippet attempts to apply a tag to just one file:

      public void applyTag(String tag, File projectFolder, String filename, ScmRepository scmRepository, ScmProvider scmProvider)

      { ScmFileSet fileSet = new ScmFileSet(projectFolder, new File(filename)); scmProvider.tag(scmRepository, fileSet, tag); }

      Lets say the given tag is "TAG_NAME" and the filename is "Example.java", then this is what CVS command is generated:

      cvs -z3 -f -q tag -F -c TAG_NAME

      The correct CVS command should be:

      cvs -z3 -f -q tag -F -c TAG_NAME Example.java

      The problem appears to be in the following method:

      org.apache.maven.scm.provider.cvslib.command.tag.AbstractCvsTagCommand.executeTagCommand(ScmProviderRepository,ScmFileSet,String,String)

      The method needs to call getFileList() on the ScmFileSet to see if any individual files are present and then add them to the generated CVS tag command.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              paullissak Paul Lissak
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: