[SCM-431] Username and Password cause NumberFormatException in scm:hg:http URLS

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4
• Component/s: maven-scm-provider-mercurial (hg)
• Environment: Hg version: 1.1+20081202; MacOSX 10.5.4; Java version "1.6.0_07"; Maven version: 2.0.6
• Flags: Patch
• Assignee: Olivier Lamy
• Reporter: Andrew Denyes
• Created: 17/Dec/08 20:30
• Updated: 05/Apr/15 14:53
• Resolved: 08/Jul/10 17:06

Description

This only affects Mercurial repository URLS using http protocol.

We are using the hgwebdir CGI along with HTTP basic auth. SCM operations during release:prepare fail because http auth is not provided to the cgi frontend to the repo. Adding the auth credentials to the URL results in NumberFormatException.

The following scm element results in number parse exception, because the colon is parsed during host and port parsing, instead of user/pass parsing.

<scm>
<connection>scm:hg:http://adenyes:[e-mail]/code/ebi</connection>
<developerConnection>scm:hg:http://adenyes:[e-mail]/code/ebi</developerConnection>
</scm>

Suggested fix: return needsAuthentication true for HTTP URLs that contain an @ symbol,
or
always parse for user/pass and always include in URI if they are set.