[SCM-338] NullPointerException when using -DvssDirectory to set ss.exe path

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1
• Component/s: maven-scm-provider-vss
• Environment: Windows XP, JRE 1.4.2
• Flags: Patch
• Assignee: Emmanuel Venisse
• Reporter: Allan Lang
• Created: 02/Sep/07 05:57
• Updated: 05/Apr/15 14:53
• Resolved: 15/May/08 14:30

Description

NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:

Caused by: java.lang.NullPointerException
        at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
        at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
        at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
        at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
        at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
        at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
        ... 21 more

This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run

mvn scm:changelog -DvssDirectory=something -e

Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.