Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-246

p4 command reports most or all errors on stderr but maven-scm-provider-perforce throws away stderr

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.2
    • None
    • Patch

    Description

      This applies to most or all commands in maven-scm-provider-perforce. I was unable to fix some basic scm configuration issues until I downloaded the maven-scm-provider-perforce source and hacked it to consume and report the p4 command's stderr as well as stdout.

      The attached patch fixes the problem for diff, checkin, checkout and tag. My solution naively consumes stdout until it is finished and then consums stderr. This isn't ideal if the output order is significant, but for the errors situations I was dealing with, it worked fine. I had a brief search for an InputStreamMultiplexer but found nothing. I have included todos to improve this.

      There is much potential for reuse between the classes in maven-scm-provider-perforce, I have included todo's stating as such.

      I have not fixed all the perforce commands. Sorry.

      Attachments

        1. scm-246.patch
          5 kB
          Peter Janes
        2. maven-scm-provider-perforce.patch
          10 kB
          Tom Parker

        Activity

          People

            siveton Siveton Vincent
            carrott Tom Parker
            Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: