Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-168

PerforceChangeLogConsumer should use relative paths

    XMLWordPrintableJSON

Details

    Description

      It seems like all scm providers are dealing with relative paths, rather than absolute repository paths. PerforceCheckOutCommand is definitely doing this. PerforceChangeLogConsumer, however, does not, which means ChangeSet.containsFilename always returns false because it's comparing a relative path to an absolute one.

      There are two changes. First, in PerforceChangeLogCommand:

      PerforceChangeLogConsumer consumer = new PerforceChangeLogConsumer( ((PerforceScmProviderRepository) repo).getPath(), startDate, endDate );
      

      The attached diff is for the second set of changes, which are to PerforceChangeLogConsumer.

      Attachments

        1. PerforceChangeLogConsumer.diff
          0.5 kB
          John Didion

        Activity

          People

            mperham Mike Perham
            jdidion John Didion
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: