[SCB-651] QPS rate limit bug

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: java-chassis-1.0.0-m1
• Fix Version/s: java-chassis-1.0.0
• Component/s: Java-Chassis
• Assignee: Sean Li
• Reporter: Sean Li
• Created: 07/Jun/18 03:10
• Updated: 22/Jun/18 22:54
• Resolved: 19/Jun/18 03:09

Description

When setting servicecomb.flowcontrol.Provider.qps.limit.[ServiceName], the actual number of requests allowed per second are 1 less than the limit value.  

For example, if I set flowcontrol.Provider.qps.limit.
business-service-consumer as 1, I'll get NO successful request at the very beginning, although I would expect 1 successful request instead of none. Similarly, if I set flowcontrol.Provider.qps.limit.
business-service-consumer as 2, I'll get 1 successful request instead of 2. 
 
However, if I pause before sending requests, for example add Thread.sleep(100) before invoking the first request, the number of requests allowed per second will be correct this time. (i.e. 1 successful request when limit value is 1, 2 successful requests when limit value is 2, etc.)
 

Issue Links

• links to: GitHub Pull Request #770