[SCB-1414] Roundbin load balancing algorithm optimizes performance by using sync/atomic instead of mutex.

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: mesher
• Assignee: Unassigned
• Reporter: chenshuo
• Created: 04/Aug/19 03:06
• Updated: 04/Aug/19 03:30

Description

Mersher and servicecenter are implemented by go-chassiss.The roundbin load balancing algorithm in go-chassis use function 'pick'.

The function 'pick' in go-chassis use mutex to add cursor value. Can we use sync/atomic to get better performance?

func pick(key string) int {
mu.RLock()
i, ok := rrIdxMap[key]
if !ok {
mu.RUnlock()
mu.Lock()
i, ok = rrIdxMap[key]
if !ok

{ i = rand.Int() rrIdxMap[key] = i }

rrIdxMap[key]++
mu.Unlock()
return i
}

mu.RUnlock()
mu.Lock()
rrIdxMap[key]++
mu.Unlock()
return i
}