[SCB-1402] BeanUtils.getImplClassFromBean can not return correctly info in cglib proxy situation

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: java-chassis-1.2.1
• Fix Version/s: java-chassis-1.3.0
• Component/s: Java-Chassis
• Assignee: Ang Li
• Reporter: Ang Li
• Created: 29/Jul/19 06:39
• Updated: 22/Aug/19 06:34
• Resolved: 06/Aug/19 06:37

Description

I found a problem using org.apache.servicecomb.foundation.common.utils.BeanUtils#getImplClassFromBean. If the @param bean is a cgLib proxy subclass bean, the getImplClassFromBean method will return null instead of super class which is expected. To make the issure more clearly, I created a bean class as following:

static class TestBean{

}

static class TestBean$$TestBeanByCGLIB$$e1a36bab extends TestBean implements SpringProxy {

}

The case is to simulate a bean class proxied by cglib proxy.A test case provided as following and the case is not past.

@Test
public void testGetImplClassFromBeanfromCglib()

{   TestBean testBeanByCGLIB = *new* TestBean$$TestBeanByCGLIB$$e1a36bab();   Assert._assertEquals_(TestBean.*class*, BeanUtils._getImplClassFromBean_(testBeanByCGLIB)); }

This matters because cglib proxy can be used while using serviceComb framework and I think just a few lines of code changing can fix this issue.

Issue Links

• links to: GitHub Pull Request #1281