[SCB-1304] FallbackPolicy interface support returns an exception

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: java-chassis-1.3.0
• Component/s: Java-Chassis
• Assignee: pengliang
• Reporter: pengliang
• Created: 30/May/19 07:26
• Updated: 29/Aug/19 14:27
• Resolved: 29/Aug/19 14:27

Description

WHY

The service downgrade function opens the org.apache.servicecomb.bizkeeper.FallbackPolicy interface for users to extend the downgrade function, but the getFallbackResponse method of the interface only accepts Invocation, and does not receive exception information, causing the user to extend the interface to generate a downgrade response without knowing that the request failed. Due to what kind of abnormality, it may cause problems such as the retry mechanism does not take effect.

WHAT

Satisfying conditions will definitely happen

HOW

org.apache.servicecomb.bizkeeper.FallbackPolicyManager.getFallbackResponse(String type, Throwable error, Invocation invocation) Change the call to the FallbackPolicy interface, pass in the Throwable

 

Issue Links

• links to: GitHub Pull Request #1226
• links to: GitHub Pull Request #1231