Uploaded image for project: 'Apache ServiceComb'
  1. Apache ServiceComb
  2. SCB-1197

enhance provider tracing handler to inherit spans from http header

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • Java-Chassis
    • None

    Description

      https://github.com/apache/servicecomb-java-chassis/issues/1116

      currently we already inherit traceId from http header in: org.apache.servicecomb.core.Invocation#initTraceId(org.apache.servicecomb.core.tracing.TraceIdGenerator)

       

      to inherit spans from http header we need to change:

      org.apache.servicecomb.tracing.zipkin.ZipkinProviderDelegate#INVOCATION_STRING_GETTER,    (if key is SPAN_ID_HEADER_NAME)

      1. try to get from invocation.context, if already exists then return directly
      2. if invocation.requestEx is no null, try to get from http header
      3. if still can not get spanId, then make spanId equals traceId

       

      maybe this is enough, but i'm not sure, need to test.

      Attachments

        Activity

          People

            Unassigned Unassigned
            wujimin Jimin Wu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: