Details
-
Task
-
Status: Closed
-
Major
-
Resolution: Won't Fix
-
None
-
None
-
None
Description
https://github.com/apache/servicecomb-java-chassis/issues/1116
currently we already inherit traceId from http header in: org.apache.servicecomb.core.Invocation#initTraceId(org.apache.servicecomb.core.tracing.TraceIdGenerator)
to inherit spans from http header we need to change:
org.apache.servicecomb.tracing.zipkin.ZipkinProviderDelegate#INVOCATION_STRING_GETTER, (if key is SPAN_ID_HEADER_NAME)
- try to get from invocation.context, if already exists then return directly
- if invocation.requestEx is no null, try to get from http header
- if still can not get spanId, then make spanId equals traceId
maybe this is enough, but i'm not sure, need to test.