Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
Attachments
Issue Links
- links to
Activity
little-cui commented on issue #491: SCB-1027 Fix the core dump in SC which compiled with go1.10+
URL: https://github.com/apache/servicecomb-service-center/pull/491#issuecomment-439035040
#485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
codecov-io commented on issue #491: SCB-1027 Fix the core dump in SC which compiled with go1.10+
URL: https://github.com/apache/servicecomb-service-center/pull/491#issuecomment-439041227
- [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=h1) Report
> Merging 491(https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/cd33623824280c7fdfc5605cd68757e80e9cd03c?src=pr&el=desc) will *increase* coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/491/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=tree)
```diff
@@ Coverage Diff @@
-
- master #491 +/- ##
==========================================
+ Coverage 59.72% 59.73% +0.01%
==========================================
Files 165 165
Lines 13796 13796
==========================================
+ Hits 8239 8241 +2
Misses 4973 4973
+ Partials 584 582 -2
```
- master #491 +/- ##
[Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=tree) | Coverage Δ | |
— | — | — |
[server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/491/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: |
[server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/491/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
[server/service/rule.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/491/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `69.51% <0%> (+0.37%)` | :arrow_up: |
[server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/491/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `90% <0%> (+10%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=continue).
> *Legend* - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=footer). Last update [cd33623...2076435](https://codecov.io/gh/apache/servicecomb-service-center/pull/491?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
little-cui closed pull request #491: SCB-1027 Fix the core dump in SC which compiled with go1.10+
URL: https://github.com/apache/servicecomb-service-center/pull/491
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/integration-grafana.md b/docs/integration-grafana.md
index 3e2d22bb..29a1bb4c 100644
— a/docs/integration-grafana.md
+++ b/docs/integration-grafana.md
@@ -8,4 +8,7 @@ can be imported in Grafana.
After the import, you can get the view like blow.
-![Grafana](/docs/integration-grafana.PNG)
\ No newline at end of file
+![Grafana](/docs/integration-grafana.PNG)
+
+Note: As the template has an ASF header, please remove the header first
+if you import this template file.
\ No newline at end of file
diff --git a/scripts/release/make_release.sh b/scripts/release/make_release.sh
index 70990570..fe965f18 100755
— a/scripts/release/make_release.sh
+++ b/scripts/release/make_release.sh
@@ -59,7 +59,7 @@ esac
export GOARCH=${4:-"amd64"}
export CGO_ENABLED=${CGO_ENABLED:-0} # prevent to compile cgo file
export GO_EXTLINK_ENABLED=${GO_EXTLINK_ENABLED:-0} # do not use host linker
export GO_LDFLAGS=${GO_LDFLAGS:"-linkmode 'external' -extldflags '-static' -s -w"}
+export GO_LDFLAGS=${GO_LDFLAGS:-" -s -w"}
root_path=$(cd "$(dirname "$0")"; pwd)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
coveralls commented on issue #491: SCB-1027 Fix the core dump in SC which compiled with go1.10+
URL: https://github.com/apache/servicecomb-service-center/pull/491#issuecomment-439041414
[![Coverage Status](https://coveralls.io/builds/20122196/badge)](https://coveralls.io/builds/20122196)
Coverage increased (+0.07%) to 62.196% when pulling *207643595141091597d5bda590f795a75c654565 on little-cui:master* into *cd33623824280c7fdfc5605cd68757e80e9cd03c on apache:master*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
little-cui opened a new pull request #491:
SCB-1027Fix the core dump in SC which compiled with go1.10+URL: https://github.com/apache/servicecomb-service-center/pull/491
Follow this checklist to help us incorporate your contribution quickly and easily:
—
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org