[SANTUARIO-568] DSIGReference is missing a header guard

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: C++ 2.0.0, C++ 2.0.1, C++ 2.0.2
• Fix Version/s: C++ 2.0.3
• Component/s: C++
• Assignee: Scott Cantor
• Reporter: Michał Kowalczyk
• Created: 22/Apr/21 10:18
• Updated: 19/Oct/21 12:37
• Resolved: 14/Oct/21 20:25

Description

The file under consideration:
https://svn.apache.org/repos/asf/santuario/xml-security-cpp/trunk/xsec/dsig/DSIGReference.hpp

Reproduction steps:
Compile a cpp file with DSIGReference.hpp included twice:

#include <xsec/dsig/DSIGReference.hpp>
#include <xsec/dsig/DSIGReference.hpp>

Current behavior:
The compiler fails due to redefinition of symbols:

In file included from XXX.cpp:1:
/usr/include/xsec/dsig/DSIGReference.hpp:71:19: error: redefinition of 'class DSIGReference'

 71 | class XSEC_EXPORT DSIGReference {
 | ^~~~~~~~~~~~~
In file included from XXX.cpp:2:
/usr/include/xsec/dsig/DSIGReference.hpp:71:19: note: previous definition of 'class DSIGReference'
 71 | class XSEC_EXPORT DSIGReference {
 | ^~~~~~~~~~~~~

Expected behavior:
Compiler succeeds.

I'd be happy to fix that but I haven't found any guide for contributors.