[SANTUARIO-552] AbstractBufferingOutputProcessor removes processor from the wrong chain in doFinal

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Java 2.1.5
• Fix Version/s: Java 2.2.1
• Component/s: Java
• Assignee: Colm O hEigeartaigh
• Reporter: Peter De Maeyer
• Created: 13/Jun/20 19:53
• Updated: 14/Dec/20 06:46
• Resolved: 17/Jun/20 16:22

Description

I've been trying to understand output processors and their chains in the context of some other fixes I'm working on.
I noticed that AbstractBufferingOutputProcessor.doFinal removes itself from the subOutputProcessorChain, which doesn't seem to make sense.
I think that should be the outputProcessorChain, which would make much more sense:
when a buffering output processor is finalized, its job is done and removes itself from the chain.
Removing itself from the subchain is useless.
In practice, there is no impact since all existing implementations call doFinal after they're done processing anyway, so it doesnt' really matter what state the output processor chain is in anymore, but I can imagine some theoretical implementations where this will cause a problem.

Issue Links

• links to: GitHub Pull Request #5