[SANTUARIO-474] Better overflow checking

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: C++ 1.7.3
• Fix Version/s: C++ 2.0.0
• Component/s: C++
• Assignee: Scott Cantor
• Reporter: Ferenc Wágner
• Created: 08/Sep/17 12:01
• Updated: 27/Jun/18 15:28
• Resolved: 11/Sep/17 02:00

Description

While looking at those few remaining compiler warnings, I encountered code in safeBuffer::checkAndExpand like this:

if (size + 1 < bufferSize) 
        return;
// Make the new size twice the size of the new string requirement 
xsecsize_t newBufferSize = size * 2; 

(We're dealing with unsigned quantities here.)
Shouldn't there be overflow checks everywhere?