[SANTUARIO-377] Proposed implementation change for ResourceResolverSpi

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Java 2.0.0
• Fix Version/s: Java 2.0.0
• Component/s: Java
• Assignee: Colm O hEigeartaigh
• Reporter: Michael Haeusler
• Created: 05/Feb/14 14:52
• Updated: 01/May/14 14:18
• Resolved: 05/Feb/14 15:57

Description

I just migrated an application from Santuario 1.5.x to 2.0.0-rc1

The migration was rather painless, which is good
however I noticed one API change that would have been much more obvious if the implementation of org.apache.xml.security.utils.resolver.ResourceResolverSpi
would be different.

public boolean engineCanResolveURI(ResourceResolverContext context)
and
public XMLSignatureInput engineResolveURI(ResourceResolverContext context)
both have a default implementation that just throws a UnsupportedOperationException.

My proposal is to change these methods to be abstract methods.
That way the compiler will immediately point out the API change when migrating.