[SANTUARIO-349] Update JCP dsig code to simplify serialization

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Java 1.5.2, Java 1.5.3
• Fix Version/s: Java 2.0.0
• Component/s: Java
• Security Level: Public (Public issues, viewable by everyone)
• Labels: enhancement serialization
• Assignee: Colm O hEigeartaigh
• Reporter: Eric Johnson
• Created: 21/Nov/12 19:55
• Updated: 18/Feb/19 13:09
• Resolved: 19/Dec/12 16:19

Description

In working on the Santuario port to GenXDM, I discovered that the serialization code for the org.apache.jcp.xml.dsig.internal.dom package turns out to be highly repetitive.

For example, code like this:

Document ownerDoc = DOMUtils.getOwnerDocument(parent);
// prepend namespace prefix, if necessary
Element knElem = DOMUtils.createElement(ownerDoc, "KeyName",
XMLSignature.XMLNS, dsPrefix);
knElem.appendChild(ownerDoc.createTextNode(name));
parent.appendChild(knElem);

can be replaced by:

xwriter.writeTextElement(dsPrefix, "KeyName", XMLSignature.XMLNS, keyName.getName());

... which both reduces the amount of code, and better exposes the intent.

Issue Links

• is related to: SANTUARIO-501 Backout patch for SANTUARIO-349