[SANTUARIO-286] Test case Santuario273.testC14n11Base() tests for a side-effect of canonicalization, rather than the desired effect

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Java 1.4.6
• Fix Version/s: Java 1.4.7
• Component/s: Java
• Security Level: Public (Public issues, viewable by everyone)
• Assignee: Colm O hEigeartaigh
• Reporter: Eric Johnson
• Created: 31/Oct/11 12:39
• Updated: 14/May/12 08:50
• Resolved: 01/Nov/11 09:47

Description

This test case, added in the 1.4.6 release, does the following:

NamedNodeMap attributes = signedInfo.getAttributes();
boolean foundBase = false;
for (int i = 0; i < attributes.getLength(); i++) {
Node attribute = attributes.item;
if ("base".equals(attribute.getLocalName())
&& "http://www.acme.com/resources/subresources/".equals(attribute.getNodeValue()))

{ foundBase = true; break; }

}
if (!foundBase)

{ fail("The base attribute was not found or was incorrect"); }

However, if you inspect the above, you'll notice that what it is doing is verifying a change to the input document, rather than verifying that the output is correct.

I ran across this issue when porting the Santuario library to use the GenXDM library, and the ported version of the c14n code does not modify the input document, which means that this test fails after the port.

I could change my port of the library to actually modify the original document - as an optional feature - but that seems like an anti-feature, rather than a benefit, so I'm requesting that the test case itself be updated.

Patch to follow.