[SANDBOX-462] Refactoring of AccessibleObjectsRegistry

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: BeanUtils2
• Assignee: Unassigned
• Reporter: Andre Diermann
• Created: 16/Feb/14 11:15
• Updated: 02/May/14 10:47

Description

Summary:
The AccessibleObjectsRegistry class provides two get methods, while one is a convenient method for the other.

Both methods take one conditional parameter, boolean exact, and the actual get method is very long, which makes it somehow complex to understand.

Suggestion:
What could be improved IMHO:

• Instead of using conditional methods, like get(boolean doSomethingSpecialIfTrue, ...), it is more convenient to provide dedicated methods like getSomething() and getAnotherThing().
• In this regard the difference between an exact or, let's call it, matching descriptor should be expressed through inheritance rather than object allocation (= expressing it by a field boolean exact).
• The very long get method should be refined
• Another very minor issue is the naming of the paramTypes field within the inner AccessibleObjectDescriptor class, which I would suggest to rename to parameterTypes to fit the naming of the other occurrences.