Uploaded image for project: 'Commons Sandbox'
  1. Commons Sandbox
  2. SANDBOX-395

Correct names for classes and variables related to operations on weights

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • Graph

    Description

      Hi all,

      as discussed in ML already the current classes/variables that refer to operations on weights can be renamed for better expressiveness:

      • all the classes under weight.primitive should be renamed from XXX to XXXOperations because they actually contain operations on weights (they do not represent weights themselves);
      • in the actual algorithms, all variable names for weight operations should actually be something like weightOperations instead of the name of the interface (e.g. orderedMonoid).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            claudio.squarcella Claudio Squarcella
            claudio.squarcella Claudio Squarcella
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment