Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-982

Add null check for offset update in OffsetManager

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      During the process of making offsetManager thread-safe, I changed the impl of lastProcessedOffsets to use ConcurrentHashMap. However, I didn't realize offset can be null so it will trigger null pointer exception when ConcurrentHashMap.put(key, null). The fix will add the null check so null offset will be still supported such as in our hello-samza example.

        Attachments

        1. SAMZA-982.0.patch
          2 kB
          Xinyu Liu

          Activity

            People

            • Assignee:
              xinyu Xinyu Liu
              Reporter:
              xinyu Xinyu Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: