Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-866

Refactor and fix Container allocation logic.

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.10.1
        • Component/s: None
        • Labels:
          None

          Description

          Bug:
          ContainerAllocator and HostAwareContainerAllocator have different try-catch logic in their run() methods. The HostAwareContainerAllocator try-catch is outside the while loop, which would cause it to stop allocating containers in the event of an exception. ContainerAllocator correctly has the try-catch inside the loop

          1. Text File
            SAMZA-866_2.patch
            17 kB
            Jake Maes
          2. Text File
            SAMZA-866.patch
            17 kB
            Jake Maes

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jmakes Jake Maes added a comment -

            Fix:

            • Refactor the loop and try-catch to a common run() method in AbstractContainerAllocator
            • Change the log type to WARN for the general exception case
            • Refactor some duplicate code in ContainerRequestState
            Show
            jmakes Jake Maes added a comment - Fix: Refactor the loop and try-catch to a common run() method in AbstractContainerAllocator Change the log type to WARN for the general exception case Refactor some duplicate code in ContainerRequestState
            Hide
            Permalink
            jmakes Jake Maes added a comment -

            Attaching patch

            Review Board: https://reviews.apache.org/r/43074/

            Show
            jmakes Jake Maes added a comment - Attaching patch Review Board: https://reviews.apache.org/r/43074/
            Hide
            Permalink
            jmakes Jake Maes added a comment -

            Uploaded patch with review comments addressed.

            Please use SAMZA-866_2.patch

            Show
            jmakes Jake Maes added a comment - Uploaded patch with review comments addressed. Please use SAMZA-866 _2.patch
            Hide
            Permalink
            nickpan47 Yi Pan (Data Infrastructure) added a comment -

            +1. Merged and submitted. Thanks!

            Show
            nickpan47 Yi Pan (Data Infrastructure) added a comment - +1. Merged and submitted. Thanks!

              People

              • Assignee:
                jmakes Jake Maes
                Reporter:
                jmakes Jake Maes
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development