Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-838

negative rocksdb.ttl.ms is not handled correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.1
    • Component/s: None
    • Labels:
      None

      Description

      Samza supports TTL since SAMZA-537 . From https://github.com/facebook/rocksdb/wiki/Time-to-Live, if ttl is negative, ttl won't happen. But in Samza code base(RocksDbKeyValueStore.scala), if user specifies negative rocksdb.ttl.ms, Samza will treat it as 1 second ttl. I am not sure if this is intended or just a trivial bug. I could provide a quick fix for this issue if needed.

      1. SAMZA-838.1.patch
        1 kB
        Tao Feng
      2. SAMZA-838.2.patch
        1 kB
        Tao Feng

        Activity

        Hide
        nickpan47 Yi Pan (Data Infrastructure) added a comment -

        Hi, Tao Feng, this seems to be a bug. We should honor the semantic definition rocksdb defines for negative TTL values.

        Show
        nickpan47 Yi Pan (Data Infrastructure) added a comment - Hi, Tao Feng , this seems to be a bug. We should honor the semantic definition rocksdb defines for negative TTL values.
        Hide
        TaoFeng Tao Feng added a comment -
        Show
        TaoFeng Tao Feng added a comment - rb at https://reviews.apache.org/r/41365/
        Hide
        navina Navina Ramesh added a comment -

        Tao Feng Can you verify that the RB and patch match? I suspect they are different and I don't know which one to use for committing.

        Show
        navina Navina Ramesh added a comment - Tao Feng Can you verify that the RB and patch match? I suspect they are different and I don't know which one to use for committing.
        Hide
        TaoFeng Tao Feng added a comment -

        Navina Ramesh, The v2 patch should be the one matched rb.

        Show
        TaoFeng Tao Feng added a comment - Navina Ramesh , The v2 patch should be the one matched rb.
        Hide
        navina Navina Ramesh added a comment -

        Ok. Got it. I think the RB showed the indentation changes as green '>' and not as a change. That's why I got confused. Will merge it. Thanks!

        Show
        navina Navina Ramesh added a comment - Ok. Got it. I think the RB showed the indentation changes as green '>' and not as a change. That's why I got confused. Will merge it. Thanks!
        Hide
        navina Navina Ramesh added a comment -

        Committed. Thanks!

        Show
        navina Navina Ramesh added a comment - Committed. Thanks!

          People

          • Assignee:
            TaoFeng Tao Feng
            Reporter:
            TaoFeng Tao Feng
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development