Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0, 0.9.1
    • Component/s: docs
    • Labels:

      Description

      While building master, I noticed that samza-api spews a couple of warnings:

      /Users/criccomini/Code/samza/samza-api/src/main/java/org/apache/samza/task/TaskContext.java:52: warning: no @param for ssp
        void setStartingOffset(SystemStreamPartition ssp, String offset);
             ^
      /Users/criccomini/Code/samza/samza-api/src/main/java/org/apache/samza/task/TaskContext.java:52: warning: no @param for offset
        void setStartingOffset(SystemStreamPartition ssp, String offset);
             ^
      2 warnings
      

      We should add some param javadocs, or clean this up.

      1. SAMZA-712.0.9.1.patch
        2 kB
        Yi Pan (Data Infrastructure)
      2. SAMZA-712.0.patch
        2 kB
        József Márton Jung

        Activity

        Hide
        nickpan47 Yi Pan (Data Infrastructure) added a comment -

        Since just doc changes, committed to both 0.9.1 and master. Thanks!

        Show
        nickpan47 Yi Pan (Data Infrastructure) added a comment - Since just doc changes, committed to both 0.9.1 and master. Thanks!
        Hide
        nickpan47 Yi Pan (Data Infrastructure) added a comment -

        The same patch is applicable to 0.9.1. Verified via build that the warning is gone. Since it is just document change to fix the warning, no new RB.

        Patch attached.

        Show
        nickpan47 Yi Pan (Data Infrastructure) added a comment - The same patch is applicable to 0.9.1. Verified via build that the warning is gone. Since it is just document change to fix the warning, no new RB. Patch attached.
        Hide
        jjung József Márton Jung added a comment - - edited

        Lately I compiled Samza a lot of times, so I added Javadocs to fix the warning when compiling.

        Then I spotted this ticket, so here is the patch for this.

        RB link: https://reviews.apache.org/r/35560/

        Show
        jjung József Márton Jung added a comment - - edited Lately I compiled Samza a lot of times, so I added Javadocs to fix the warning when compiling. Then I spotted this ticket, so here is the patch for this. RB link: https://reviews.apache.org/r/35560/

          People

          • Assignee:
            jjung József Márton Jung
            Reporter:
            criccomini Chris Riccomini
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development