[SAMZA-2747] Standby bug fixes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8
• Assignee: Bharath Kumarasubramanian
• Reporter: Bharath Kumarasubramanian
• Created: 07/Jun/22 00:25
• Updated: 16/Dec/22 17:40
• Resolved: 16/Dec/22 17:40

Description

Problem:

• Standby feature is broken for jobs that don't have explicit side inputs
• Change logged stores are treated as non-change logged for standby containers

Description:

PR 1367 - Introduced a bug where jobs with no side inputs caused jobs to not bootstrap data for logged stores. The root cause was related to mutation of taskSideInputStoreSSPs as changelogSSPs that were added to it during initialization were ignored since the initialization of hasSideInputs happened before.

PR 1491 - Introduced a bug where the logged stores were incorrectly classified as non-logged stores for standby container resulting in discarding of state at the end of container lifecycle. The root cause was similar to above where sideInputStoreNames was initialized prior to updating changelogSSPs 

Bottom line: Mutation of certain fields related to side inputs were out of order and refactor PRs (1367 and 1491) were not aware of this assumption.