Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-2680

Remove wildcard import

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Trivial
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      SystemStreamPartitionGrouper uses a wildcard import. The wildcard import should be removed and replaced by specific imports. An example of what this change involves is as follows:

      diff --git a/samza-api/src/main/java/org/apache/samza/container/grouper/stream/SystemStreamPartitionGrouper.java b/samza-api/src/main/java/org/apache/samza/container/grouper/stream/SystemStreamPartitionGrouper.java
      index 60760762c..0f4b473d1 100644
      --- a/samza-api/src/main/java/org/apache/samza/container/grouper/stream/SystemStreamPartitionGrouper.java
      +++ b/samza-api/src/main/java/org/apache/samza/container/grouper/stream/SystemStreamPartitionGrouper.java
      @@ -18,8 +18,8 @@
        */
       package org.apache.samza.container.grouper.stream;
      
      -import java.util.*;
      -
      +import java.util.Map;
      +import java.util.Set;
       import org.apache.samza.container.TaskName;
       import org.apache.samza.system.SystemStreamPartition;
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            jonbringhurst Jon Bringhurst
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m