[SAMZA-2447] Checkpoint dir removal should only search in valid store dirs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.4
• Assignee: Brett Konold
• Reporter: Brett Konold
• Created: 28/Jan/20 08:24
• Updated: 28/Feb/20 19:02
• Resolved: 28/Feb/20 19:02

Description

removeOldCheckpoints in TransactionalStateTaskStorageManager currently treats every file in the logged store base directory as if it is a directory; not always true as there is no guarantee that the base directory has only stores in it (there could be other files unrelated to stores depending on how the user has configured the directory).

We should only be calling listFiles on files that we know to be directories.

Bonus points if we can search only directories we know to be stores

Issue Links

• links to: GitHub Pull Request #1261