Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-2447

Checkpoint dir removal should only search in valid store dirs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      removeOldCheckpoints in TransactionalStateTaskStorageManager currently treats every file in the logged store base directory as if it is a directory; not always true as there is no guarantee that the base directory has only stores in it (there could be other files unrelated to stores depending on how the user has configured the directory).

      We should only be calling listFiles on files that we know to be directories.

      Bonus points if we can search only directories we know to be stores

        Attachments

          Activity

            People

            • Assignee:
              bkonold Brett Konold
              Reporter:
              bkonold Brett Konold

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                  Issue deployment