[SAMZA-2036] MessageStreamAssert.containsInAnyOrder does not fail if there is an error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 1.0.1
• Assignee: Unassigned
• Reporter: Cameron Lee
• Created: 11/Dec/18 18:55
• Updated: 26/Feb/19 00:51
• Resolved: 12/Dec/18 00:01

Description

MessageStreamAssert.containsInAnyOrder uses a java.util.Timer to do verification. However, Timer will do the check in a background thread, and any error/exception does not get propagated to the main thread for the test. Therefore, any error will not cause a test to fail, so a test will pass even if there is an issue.

In addition, the MessageStreamAssert.CheckAgainstExpected helper class is broken, since the "expected" messages get cleared out when the operator graph is serialized then deserialized, and an NPE is thrown when trying to run "apply". This is already covered in https://issues.apache.org/jira/browse/SAMZA-1829.

SchedulingTest and TestRepartitionJoinWindowApp both use MessageStreamAssert.containsInAnyOrder, and they pass, but they should fail.