Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1414

SamzaContainer log statements incorrectly expect containerId is a number

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:

      Description

      The line numbers wont match up with the latest, but here's a stack trace.

      java.util.IllegalFormatConversionException: d != java.lang.String
          at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
          at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
          at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
          at java.util.Formatter.format(Formatter.java:2520)
          at java.util.Formatter.format(Formatter.java:2455)
          at java.lang.String.format(String.java:2940)
          at scala.collection.immutable.StringLike$class.format(StringLike.scala:266)
          at scala.collection.immutable.StringOps.format(StringOps.scala:31)
          at org.apache.samza.container.SamzaContainer$$anonfun$startLocalityManager$4.apply(SamzaContainer.scala:857)
          at org.apache.samza.container.SamzaContainer$$anonfun$startLocalityManager$4.apply(SamzaContainer.scala:857)
          at org.apache.samza.util.Logging$class.warn(Logging.scala:74)
          at org.apache.samza.container.SamzaContainer.warn(SamzaContainer.scala:640)
          at org.apache.samza.container.SamzaContainer.startLocalityManager(SamzaContainer.scala:856)
          at org.apache.samza.container.SamzaContainer.run(SamzaContainer.scala:684)
          at org.apache.samza.runtime.LocalContainerRunner.run(LocalContainerRunner.java:104)
          at org.apache.samza.runtime.LocalContainerRunner.main(LocalContainerRunner.java:149)
      

      Looks like the log statements need to expect containerId as a string.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dnishimura opened a pull request:

          https://github.com/apache/samza/pull/298

          SAMZA-1414: SamzaContainer log statements incorrectly expect containerId is a number

          Correctly log ID as a string in SamzaContainer.
          @jmakes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dnishimura/samza samza-1414

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/298.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #298


          commit d83cf3ab499a0ca339d2801a36ee18f2ddf15588
          Author: Daniel Nishimura <dnishimura@gmail.com>
          Date: 2017-09-19T20:53:00Z

          Correctly log ID as a string in SamzaContainer.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dnishimura opened a pull request: https://github.com/apache/samza/pull/298 SAMZA-1414 : SamzaContainer log statements incorrectly expect containerId is a number Correctly log ID as a string in SamzaContainer. @jmakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnishimura/samza samza-1414 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #298 commit d83cf3ab499a0ca339d2801a36ee18f2ddf15588 Author: Daniel Nishimura <dnishimura@gmail.com> Date: 2017-09-19T20:53:00Z Correctly log ID as a string in SamzaContainer.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/298

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/298
          Hide
          jmakes Jake Maes added a comment -

          Issue resolved by pull request 298
          https://github.com/apache/samza/pull/298

          Show
          jmakes Jake Maes added a comment - Issue resolved by pull request 298 https://github.com/apache/samza/pull/298

            People

            • Assignee:
              Unassigned
              Reporter:
              jmakes Jake Maes
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development