Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1366

ScriptRunner should allow callers to control the child process environment.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      The ScriptRunner class used by samza-rest currently uses the defaults for ProcessBuilder to construct the child process and by default, all environment variables are forwarded to the child process.

      This causes problems with log settings (e.g. console vs file), class path, config collisions, etc.

      The goals of this ticket are:
      1. Allow the caller to dictate whether to forward the environment variables or start with a clean slate.
      2. Allow the caller to explicitly specify environment variables to add to the child environment.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jmakes opened a pull request:

          https://github.com/apache/samza/pull/245

          SAMZA-1366: ScriptRunner should allow callers to control the child pr…

          …ocess environment.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jmakes/samza script-runner-improvements

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/245.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #245


          commit 6cf0c019469b58726df7b718201d49de108ffbeb
          Author: Jacob Maes <jmaes@linkedin.com>
          Date: 2017-07-20T15:53:56Z

          SAMZA-1366: ScriptRunner should allow callers to control the child process environment.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jmakes opened a pull request: https://github.com/apache/samza/pull/245 SAMZA-1366 : ScriptRunner should allow callers to control the child pr… …ocess environment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmakes/samza script-runner-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/245.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #245 commit 6cf0c019469b58726df7b718201d49de108ffbeb Author: Jacob Maes <jmaes@linkedin.com> Date: 2017-07-20T15:53:56Z SAMZA-1366 : ScriptRunner should allow callers to control the child process environment.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/245

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/245
          Hide
          jmakes Jake Maes added a comment -

          Issue resolved by pull request 245
          https://github.com/apache/samza/pull/245

          Show
          jmakes Jake Maes added a comment - Issue resolved by pull request 245 https://github.com/apache/samza/pull/245

            People

            • Assignee:
              jmakes Jake Maes
              Reporter:
              jmakes Jake Maes
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development