Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1361

OperatorImplGraph used wrong keys to store/retrieve OperatorImpl in the map

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      The operatorsImpls in the OperatorImplGraph is using String as the lookup key, while the code to put the operatorImpl is using OperatorSpec as the key. The key used to lookup and retrieval should be consistent.

        Issue Links

          Activity

          Hide
          nickpan47 Yi Pan (Data Infrastructure) added a comment -

          An alternative solution to remove the operatorImpls map completely is to traverse the StreamGraphImpl in topo-sort order. It would be nice to consider this option as well when fixing this bug.

          Show
          nickpan47 Yi Pan (Data Infrastructure) added a comment - An alternative solution to remove the operatorImpls map completely is to traverse the StreamGraphImpl in topo-sort order. It would be nice to consider this option as well when fixing this bug.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user prateekm opened a pull request:

          https://github.com/apache/samza/pull/248

          SAMZA-1361: OperatorImplGraph is using wrong keys to store/retrieve OperatorImpl in the map

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/prateekm/samza operatorimpl-key

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/248.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #248


          commit 8eb2c5dff08e57cad41f3417d2bd0db035a4a7e1
          Author: Prateek Maheshwari <pmaheshw@linkedin.com>
          Date: 2017-07-24T18:27:19Z

          SAMZA-1361: OperatorImplGraph is using wrong keys to store/retrieve OperatorImpl in the map


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user prateekm opened a pull request: https://github.com/apache/samza/pull/248 SAMZA-1361 : OperatorImplGraph is using wrong keys to store/retrieve OperatorImpl in the map You can merge this pull request into a Git repository by running: $ git pull https://github.com/prateekm/samza operatorimpl-key Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #248 commit 8eb2c5dff08e57cad41f3417d2bd0db035a4a7e1 Author: Prateek Maheshwari <pmaheshw@linkedin.com> Date: 2017-07-24T18:27:19Z SAMZA-1361 : OperatorImplGraph is using wrong keys to store/retrieve OperatorImpl in the map
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/248

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/248

            People

            • Assignee:
              pmaheshwari Prateek Maheshwari
              Reporter:
              nickpan47 Yi Pan (Data Infrastructure)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development