Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1358

task.class empty string should be ignored when app.class is configured

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      There is a bug in TaskFactoryUtil that getTaskClass() from scala code but failed to convert to string before the string comparison.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nickpan47 opened a pull request:

          https://github.com/apache/samza/pull/242

          SAMZA-1358: fix the bug in validating task.class empty string when ap…

          …p.class is configured

          Another bug due to scala/java differences.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nickpan47/samza SAMZA-1358

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/242.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #242


          commit 196e761719df8d9401822c99e1d5b8a1b99b2f2d
          Author: Yi Pan (Data Infrastructure) <nickpan47@gmail.com>
          Date: 2017-07-11T17:21:57Z

          SAMZA-1358: fix the bug in validating task.class empty string when app.class is configured


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nickpan47 opened a pull request: https://github.com/apache/samza/pull/242 SAMZA-1358 : fix the bug in validating task.class empty string when ap… …p.class is configured Another bug due to scala/java differences. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickpan47/samza SAMZA-1358 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/242.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #242 commit 196e761719df8d9401822c99e1d5b8a1b99b2f2d Author: Yi Pan (Data Infrastructure) <nickpan47@gmail.com> Date: 2017-07-11T17:21:57Z SAMZA-1358 : fix the bug in validating task.class empty string when app.class is configured
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/242

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/242

            People

            • Assignee:
              nickpan47 Yi Pan (Data Infrastructure)
              Reporter:
              nickpan47 Yi Pan (Data Infrastructure)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development