Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0, 0.13.1
    • Component/s: None
    • Labels:
      None

      Description

      We should add a facility to complete remove all the data created by the ZkStandalone in ZK.

        Issue Links

          Activity

          Hide
          boryas Boris Shkolnik added a comment -

          It may be called from ApplicationRunner (in the app runner's leader).

          Show
          boryas Boris Shkolnik added a comment - It may be called from ApplicationRunner (in the app runner's leader).
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sborya opened a pull request:

          https://github.com/apache/samza/pull/238

          SAMZA-1165. Zk clean up old versions.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sborya/samza zkCleanUpBarrier

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/238.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #238


          commit c64323d3d1b9ab3b4558937d42ae39a2f7ec781c
          Author: Boris Shkolnik <bshkolni@bshkolni-ld1.linkedin.biz>
          Date: 2017-06-21T22:41:59Z

          add generation number for each ZKListener

          commit f2211193c7413559c268662c47c56c2fa615c71e
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-21T22:51:04Z

          checkStyle

          commit 53943ce65d05a839f3cb8a9d64a82230599d2e9d
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-21T23:22:33Z

          more checkStyle

          commit f14fff5ab98e50b2dda0908a9ea7c689a717f24a
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-23T21:34:34Z

          somre review comments

          commit c0fe8740260d3af95769869fa6029c59ebd56a1a
          Author: Boris Shkolnik <bshkolni@linkedin.com>
          Date: 2017-06-27T17:03:55Z

          use CountDownLatch

          commit 034e5311acc5ba4ab233803b3ed5ff9d3225b5bc
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-27T17:05:56Z

          merge master

          commit adfbe7894e27e9e8af9757e9dfae74e877faaae2
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-27T17:08:52Z

          merge

          commit 71f42914cf032a7f65be2b3c3419b576628d456f
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-27T17:20:52Z

          merge + checkStyle

          commit 0cd644450ff3f8974b9092405d0389f4850016db
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-28T18:49:56Z

          cleanup

          commit 6ee13dd4b97b58b4e5610da1f5a02a7cc578bbd0
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-28T18:52:55Z

          merged

          commit b342b6c6531912aca99a60e67b16401ab3232086
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-28T19:17:42Z

          correct stop container

          commit 24fd538403459b261042b7884cd96faa0c107079
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T01:34:15Z

          addressed review comments - move from wait to countdownlatch.await

          commit 3fad1c5012c5fb2ff4d984ca24f57ba78f24fae3
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T18:45:44Z

          addressed review comments

          commit b4fea9d3268622c1cdcabb2e1816264aab547b9b
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T19:10:23Z

          checkstyle

          commit c58217e44f3ea0242151c73ca587d2de22e93beb
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T22:44:06Z

          temp comit

          commit ceb76f083e417ac3fdf1bff2a3843c789e31664d
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T22:45:48Z

          merged

          commit 9aa3965d1dfe5435a86c591df1b991371079f809
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T22:48:06Z

          cleanup

          commit 2c7084c75b509ddfb490e99b73addc9393e1ee4a
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-29T22:48:36Z

          removed cleanup

          commit 980355500cc41221758dc9a444473c0e586e0523
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-30T01:03:27Z

          clean up old versions from ZK structure


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sborya opened a pull request: https://github.com/apache/samza/pull/238 SAMZA-1165 . Zk clean up old versions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sborya/samza zkCleanUpBarrier Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #238 commit c64323d3d1b9ab3b4558937d42ae39a2f7ec781c Author: Boris Shkolnik <bshkolni@bshkolni-ld1.linkedin.biz> Date: 2017-06-21T22:41:59Z add generation number for each ZKListener commit f2211193c7413559c268662c47c56c2fa615c71e Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-21T22:51:04Z checkStyle commit 53943ce65d05a839f3cb8a9d64a82230599d2e9d Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-21T23:22:33Z more checkStyle commit f14fff5ab98e50b2dda0908a9ea7c689a717f24a Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-23T21:34:34Z somre review comments commit c0fe8740260d3af95769869fa6029c59ebd56a1a Author: Boris Shkolnik <bshkolni@linkedin.com> Date: 2017-06-27T17:03:55Z use CountDownLatch commit 034e5311acc5ba4ab233803b3ed5ff9d3225b5bc Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-27T17:05:56Z merge master commit adfbe7894e27e9e8af9757e9dfae74e877faaae2 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-27T17:08:52Z merge commit 71f42914cf032a7f65be2b3c3419b576628d456f Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-27T17:20:52Z merge + checkStyle commit 0cd644450ff3f8974b9092405d0389f4850016db Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-28T18:49:56Z cleanup commit 6ee13dd4b97b58b4e5610da1f5a02a7cc578bbd0 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-28T18:52:55Z merged commit b342b6c6531912aca99a60e67b16401ab3232086 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-28T19:17:42Z correct stop container commit 24fd538403459b261042b7884cd96faa0c107079 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T01:34:15Z addressed review comments - move from wait to countdownlatch.await commit 3fad1c5012c5fb2ff4d984ca24f57ba78f24fae3 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T18:45:44Z addressed review comments commit b4fea9d3268622c1cdcabb2e1816264aab547b9b Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T19:10:23Z checkstyle commit c58217e44f3ea0242151c73ca587d2de22e93beb Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T22:44:06Z temp comit commit ceb76f083e417ac3fdf1bff2a3843c789e31664d Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T22:45:48Z merged commit 9aa3965d1dfe5435a86c591df1b991371079f809 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T22:48:06Z cleanup commit 2c7084c75b509ddfb490e99b73addc9393e1ee4a Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-29T22:48:36Z removed cleanup commit 980355500cc41221758dc9a444473c0e586e0523 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-30T01:03:27Z clean up old versions from ZK structure
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sborya closed the pull request at:

          https://github.com/apache/samza/pull/238

          Show
          githubbot ASF GitHub Bot added a comment - Github user sborya closed the pull request at: https://github.com/apache/samza/pull/238
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sborya opened a pull request:

          https://github.com/apache/samza/pull/239

          SAMZA-1165. cleanup old zk versions.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sborya/samza zkCleanUpBarrier1

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/239.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #239


          commit 754b29ce5a906d82cfd82acd729d6c51a7533286
          Author: Boris Shkolnik <boryas@apache.org>
          Date: 2017-06-30T01:08:48Z

          cleanup old zk versions


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sborya opened a pull request: https://github.com/apache/samza/pull/239 SAMZA-1165 . cleanup old zk versions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sborya/samza zkCleanUpBarrier1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #239 commit 754b29ce5a906d82cfd82acd729d6c51a7533286 Author: Boris Shkolnik <boryas@apache.org> Date: 2017-06-30T01:08:48Z cleanup old zk versions
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/239

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/239
          Hide
          navina Navina Ramesh added a comment -

          Boris Shkolnik Are we good to resolve this issue?

          Show
          navina Navina Ramesh added a comment - Boris Shkolnik Are we good to resolve this issue?

            People

            • Assignee:
              boryas Boris Shkolnik
              Reporter:
              boryas Boris Shkolnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development