Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1121

StreamAppender should not propagate exceptions to caller

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      StreamAppender#append currently propagates any exceptions while sending messages to the underlying logging system to the calling code. Since users don't expect log statements to throw exceptions, this can cause unexpected failures.

      We should catch exceptions and log to stderr instead.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user prateekm opened a pull request:

          https://github.com/apache/samza/pull/78

          SAMZA-1121: StreamAppender should not propagate exceptions to the caller

          StreamAppender#append currently propagates any exceptions while sending messages to the underlying logging system to the calling code. Since users don't expect log statements to throw exceptions, this can cause unexpected failures scenarios. We should catch exceptions and log to stderr instead.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/prateekm/samza stream-appender-fix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/78.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #78


          commit 1809c5d2f94e414be84433160e5298ed65759ada
          Author: Prateek Maheshwari <pmaheshw@linkedin.com>
          Date: 2017-03-07T00:25:44Z

          SAMZA-1121: StreamAppender should not propagate exceptions to the caller


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user prateekm opened a pull request: https://github.com/apache/samza/pull/78 SAMZA-1121 : StreamAppender should not propagate exceptions to the caller StreamAppender#append currently propagates any exceptions while sending messages to the underlying logging system to the calling code. Since users don't expect log statements to throw exceptions, this can cause unexpected failures scenarios. We should catch exceptions and log to stderr instead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/prateekm/samza stream-appender-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit 1809c5d2f94e414be84433160e5298ed65759ada Author: Prateek Maheshwari <pmaheshw@linkedin.com> Date: 2017-03-07T00:25:44Z SAMZA-1121 : StreamAppender should not propagate exceptions to the caller
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/78

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/78
          Hide
          jagadish1989@gmail.com Jagadish added a comment -

          Thanks for the timely patch Prateek Maheshwari. merged and submitted to master!

          Show
          jagadish1989@gmail.com Jagadish added a comment - Thanks for the timely patch Prateek Maheshwari . merged and submitted to master!

            People

            • Assignee:
              pmaheshwari Prateek Maheshwari
              Reporter:
              pmaheshwari Prateek Maheshwari
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development