Uploaded image for project: 'Samza'
  1. Samza
  2. SAMZA-1112

BrokerProxy does not log fatal errors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      We hit an issue today where having a large backlog of messages to process caused an OutOfMemoryError in one our our jobs, presumably due to the BrokerProxy's default buffer size of 50k messages being too large. The issue though was that the error was not logged, and from the logs it appeared that the job just spontaneously exited.

      Looking at the BrokerProxy, there is no UncaughtExceptionHandler set for its thread, so any fatal errors only go to stderr.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user twbecker opened a pull request:

          https://github.com/apache/samza/pull/80

          SAMZA-1112:BrokerProxy does not log fatal errors

          Add an UncaughtExceptionHandler to the broker proxy thread so
          failures there get logged.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/TiVo/samza SAMZA-1112

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/samza/pull/80.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #80


          commit a2e00bbbf773e340fb1fd0617a4ac3945d58c365
          Author: Tommy Becker <tobecker@tivo.com>
          Date: 2017-03-09T20:47:46Z

          Fix SAMZA-1112

          Add an UncaughtExceptionHandler to the broker proxy thread so
          failures there get logged.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user twbecker opened a pull request: https://github.com/apache/samza/pull/80 SAMZA-1112 :BrokerProxy does not log fatal errors Add an UncaughtExceptionHandler to the broker proxy thread so failures there get logged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TiVo/samza SAMZA-1112 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit a2e00bbbf773e340fb1fd0617a4ac3945d58c365 Author: Tommy Becker <tobecker@tivo.com> Date: 2017-03-09T20:47:46Z Fix SAMZA-1112 Add an UncaughtExceptionHandler to the broker proxy thread so failures there get logged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/samza/pull/80

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/80
          Hide
          jagadish1989@gmail.com Jagadish added a comment -

          Thanks for the contribution. Merged, and submitted. Fix version: 0.13.0.

          Show
          jagadish1989@gmail.com Jagadish added a comment - Thanks for the contribution. Merged, and submitted. Fix version: 0.13.0.

            People

            • Assignee:
              twbecker Tommy Becker
              Reporter:
              twbecker Tommy Becker
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development