[SAMZA-1069] Deadlock between KafkaSystemProducer and KafkaProducer from kafka-clients lib

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Assignee: Xinyu Liu
• Reporter: Yi Pan
• Created: 22/Dec/16 23:35
• Updated: 23/Dec/16 22:33
• Resolved: 23/Dec/16 22:33

Description

We have identified one deadlock scenario between the main thread that calls KafkaSystemProducer.close() vs the KafkaProducer client lib's network thread that calls the callback function within KafkaSystemProducer.send().

The scenario is the following:

1. SamzaContainer main thread caught an exception from previous commit and container initiated shutdown, which calls KafkaSystemProducer.stop(), grabbing the synchronized producerLock in KafkaSystemProducer and call KafkaProducer.flush() to wait for all pending requests to be done.
2. KafkaProducer network I/O thread then calls KafkaSystemProducer’s callback function (in RecordBatch.done()), which is waiting on the same producerLock in KafkaSystemProducer before it can return and call producerFuture.done() and release the CountDownLatch that the main thread KafkaSystemProducer.close() is waiting on. Hence, deadlock!

We need to make sure the KafkaSystemProducer.close() won't have race condition w/ the callbacks triggered by the KafkaProducer's network thread.

Issue Links

• links to: GitHub Pull Request #37