Uploaded image for project: 'Apache S4'
  1. Apache S4
  2. S4-58

Keyed events sent by clients are injected without keys in S4 cluster

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • 0.3
    • None
    • Ubuntu Linux
      java version "1.6.0_24"
      OpenJDK Runtime Environment (IcedTea6 1.11.1) (6b24-1.11.1-4ubuntu3)
      OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)

    Description

      The method toJson in Message class converts the message into JSON but it uses a wrong field name for keys' event (https://github.com/s4/s4/blob/v0.3.0/s4-driver/java/src/main/java/io/s4/client/Message.java#L87)

      The documentation at http://docs.s4.io/manual/client_adapter.html#sending-events-into-s4-cluster says that 'keys' field should be used to send keys to adapters but the implementation uses 'keysName'.

      Here is the fix:

      if (this.keyNames != null)

      { json.put("keys", this.keyNames); }

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            davide.simoncelli Davide Simoncelli
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment