Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-76

Move orderBy, groupBy logic from PostProcess into Graph#getEdges inside.

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: In Progress
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      My suggestion in one line, is make PostProcess simply build json from result type of getEdges and make getEdges build complete query result.

      Current return type of Graph#getEdges is not sufficient enough.
      GroupBy, OrderBy, or merging multiple queries result is located on PostProcess, not inside of getEdges.

      Followings are subtasks to resolve this issue.

      1. Define better return type of getEdges.
      2. Refactor getEdges to process orderBy, groupBy.
      3. Define better representation of Edge that can be converted easily into Json or other type easily.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            steamshon Do Yung Yoon
            steamshon Do Yung Yoon

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 840h
                840h
                Remaining:
                Remaining Estimate - 840h
                840h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment